Skip to content

feat: Node.js 18.19.0, 21.3.0#2002

Closed
knksmith57 wants to merge 1 commit intonodejs:mainfrom
knksmith57:version-update
Closed

feat: Node.js 18.19.0, 21.3.0#2002
knksmith57 wants to merge 1 commit intonodejs:mainfrom
knksmith57:version-update

Conversation

@knksmith57
Copy link
Contributor

@knksmith57 knksmith57 commented Dec 1, 2023 •
edited
Loading

@knksmith57
Copy link
Contributor Author

knksmith57 commented Dec 1, 2023

Note: it doesn't look like update.sh is correctly handling the alpine image updates due to a failing checksum fetch for 18.x

❯ ./update.sh alpine
Updating version 18...
Updating version 20...
Updating version 21...
18/bookworm/Dockerfile is already up to date!
20/bookworm/Dockerfile is already up to date!
18/bullseye-slim/Dockerfile is already up to date!
18/bullseye/Dockerfile is already up to date!
18/buster-slim/Dockerfile is already up to date!
18/buster/Dockerfile is already up to date!
18/bookworm-slim/Dockerfile is already up to date!
20/buster/Dockerfile is already up to date!
20/bullseye/Dockerfile is already up to date!
**********
Fatal Error: Failed to fetch checksum for version 18.19.0
**********
20/bookworm-slim/Dockerfile is already up to date!
**********
Fatal Error: Failed to fetch checksum for version 18.19.0
**********
20/bullseye-slim/Dockerfile is already up to date!
20/alpine3.18/Dockerfile is already up to date!
20/buster-slim/Dockerfile is already up to date!
20/alpine3.17/Dockerfile is already up to date!
21/bookworm/Dockerfile is already up to date!
21/bookworm-slim/Dockerfile is already up to date!
21/bullseye/Dockerfile is already up to date!
21/bullseye-slim/Dockerfile is already up to date!
21/alpine3.17/Dockerfile is already up to date!
21/alpine3.18/Dockerfile is already up to date!
Done!

@knksmith57
Copy link
Contributor Author

knksmith57 commented Dec 1, 2023

Looks like the checksum file for 18.19.0 is missing on unofficial-builds.nodejs.org: https://unofficial-builds.nodejs.org/download/release/v18.19.0/SHASUMS256.txt

@knksmith57 knksmith57 mentioned this pull request Dec 1, 2023
Closed
@knksmith57
Copy link
Contributor Author

knksmith57 commented Dec 1, 2023

Filed nodejs/node#50997. It turns out all release artifacts for 18.19.0 for alpine are missing.

https://unofficial-builds.nodejs.org/download/release/v18.19.0/

@knksmith57
Copy link
Contributor Author

knksmith57 commented Dec 1, 2023

@richardlau has requeued the 18.19.0 release build for us 🙏: nodejs/node#50997 (comment)

@knksmith57
Copy link
Contributor Author

knksmith57 commented Dec 1, 2023

OK, alpine images are updated and things look good 💯

This is ready for review 🙏

@knksmith57
Copy link
Contributor Author

knksmith57 commented Dec 1, 2023

nvm, this is obviated by #2003

@knksmith57 knksmith57 closed this Dec 1, 2023
@knksmith57 knksmith57 deleted the version-update branch December 1, 2023 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@knksmith57